Add the distinction between actual form errors and errors displayed #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A form, if any of its fields are invalid it should be considered invalid even if the errors are not displayed for example due to the isNewModel property that does not show all field errors at the beginning. So I created the distinction between the actual errors of the form, and the errors that are being displayed in the form.
|
interesting... I'll try to review this more thoroughly and get the PR merged or my feedback back to you ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of its fields of a form are invalid the entire form should be considered invalid even if the errors are not displayed for example due to the
isNewModelproperty (which does not show all field errors at the beginning). So I created the distinction between the actual errors of the form, and the errors that are being displayed in the form.I was facing a use case where I needed to have a submit button disabled until the form was correctly filled, but neither show the validation errors until the user reached the field for the first time. With how isNewModel was implemented this behaviour was not possible, the errors were being cleaned but when
validatedevent was raised the isValid value was always true, so I introduced this functionality. If you supply isNewModel to false (the default) the behaviour is the same as it was before.