Skip to content

Conversation

k8n
Copy link

@k8n k8n commented Apr 8, 2019

Simple, but perhaps naïve change to permit visible control for groups same as for fields.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Ability to control visibility of field groups.
  • What is the current behavior? (You can also link to an open issue here)
    Groups visibility cannot be controlled. Groups are always rendered.
  • What is the new behavior (if this is a feature change)?
    Specifying visible attribute on a field group permits to control group visibility.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Don't think so.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.979% when pulling 29cc298 on k8n:patch-3 into 721a4ee on vue-generators:master.

@zoul0813
Copy link
Member

zoul0813 commented Apr 8, 2019

Looks good, simple and gets the job done ... get another contributor to approve and I’ll merge it

@muschottkey
Copy link

👍

I'm waiting on this feature to be added so that I can use the module.

Can we get it approved please? 😀

muschottkey pushed a commit to muschottkey/vue-form-generator that referenced this pull request Jul 11, 2019
I would like to be able to control the visibility of the group.
This has already been implemented in a pending PR in master
vue-generators#606

Added it to v3.
muschottkey pushed a commit to muschottkey/vue-form-generator that referenced this pull request Oct 8, 2019
I would like to be able to control the visibility of the group.
This has already been implemented in a pending PR in master
vue-generators#606

Added it to v3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants