Skip to content

fix: treeNode dataRef is undefined #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Aug 21, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
    In merge commit 00f1047, treeselect lose props treeData, it cause that treeNode.dataRef is undefined and treeselect can't dynamic load data.
  1. Resolve what problem.
  2. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 5f9ebe8

https://app.netlify.com/sites/ant-desing-vue/deploys/5d5cf2b52f6b310008fbefa7

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #1111 into feat-1.4.0 will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat-1.4.0    #1111      +/-   ##
==============================================
+ Coverage       87.62%   87.62%   +<.01%     
==============================================
  Files             155      155              
  Lines            5358     5359       +1     
  Branches         1590     1591       +1     
==============================================
+ Hits             4695     4696       +1     
  Misses            591      591              
  Partials           72       72
Impacted Files Coverage Δ
components/tree-select/index.jsx 79.24% <75%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f66fae4...5f9ebe8. Read the comment docs.

@wangxueliang wangxueliang merged commit f12d53b into vueComponent:feat-1.4.0 Aug 22, 2019
@zkwolf zkwolf deleted the fix-tree-select-dataRef-undefined branch August 22, 2019 14:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants