Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate vue-docgen-api in preview #6

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Conversation

elevatebart
Copy link
Collaborator

Using this new integration we can now leverage docgen on component pages.
I was thinking of making an extra component on the right side (collapsible) that would display all this info and allow to interract with the previews.

It has been my experience that people love to interact and modify preview examples.

@znck
Copy link
Collaborator

znck commented Sep 24, 2020

extra component on the right side
That's a nice idea, go ahead.

(collapsible)
We should make left-side collapsible too.

@elevatebart
Copy link
Collaborator Author

Here is a screenshot of the status today:

Screen Shot 2020-11-24 at 2 26 59 PM

  • Added the two collapse buttons (no animation, no design)
  • Started rendering the documentation on the right panel

@znck
Copy link
Collaborator

znck commented Nov 25, 2020

LGTM.

@elevatebart
Copy link
Collaborator Author

I will finish rendering the docs this morning. Then I will merge.

@elevatebart
Copy link
Collaborator Author

I have not gotten .__docgen__ urls to refresh using HMR. I will try to do this in a next PR.

@elevatebart elevatebart merged commit d851b96 into master Nov 30, 2020
@elevatebart elevatebart deleted the add-docgen branch November 30, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants