Add more robust SW registration snippet #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
requested changes
May 8, 2017
template/index.html
Outdated
|
|
||
| if ('serviceWorker' in navigator && | ||
| (window.location.protocol === 'https:' || isLocalhost)) { | ||
| navigator.serviceWorker.register('service-worker.js') |
There was a problem hiding this comment.
It's usually a good idea to wrap the register() in a window.onload, as per https://developers.google.com/web/fundamentals/instant-and-offline/service-worker/registration#conclusion
If there's a "better" event to listen for that's exposed as part of the Vue framework, like an event that's fired after all all the custom framework logic has completed, that would be another option to wrap it in.
|
@jeffposnick PTAL. Added the delay to post onload. |
|
👍 |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of the feedback from #12 with respect to better detecting secure origins are being used. It effectively uses a similar setup to what we originally had for Web Starter Kit.
r @jeffposnick