Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const/let instead of var #801

Merged
merged 1 commit into from
Sep 30, 2017
Merged

Use const/let instead of var #801

merged 1 commit into from
Sep 30, 2017

Conversation

sudo-suhas
Copy link
Contributor

Use of const/let is considered good practice and since the template specifies "node": ">= 4.0.0", we can safely use these.

@sudo-suhas
Copy link
Contributor Author

Rebased to fix conflict. Also added 'use strict' directive because of this:

λ node --version
v4.0.0

λ echo let a = 1 > test-node4.js

λ node test-node4.js
E:\Projects\experiments\test-node4.js:1
(function (exports, require, module, __filename, __dirname) { let a = 1
                                                              ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:413:25)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)
    at startup (node.js:117:18)
    at node.js:951:3

@LinusBorg LinusBorg changed the base branch from master to develop September 1, 2017 10:56
@LinusBorg LinusBorg added this to the 1.1.0 milestone Sep 1, 2017
LinusBorg
LinusBorg previously approved these changes Sep 1, 2017
View reviewed changes
@LinusBorg LinusBorg dismissed their stale review September 1, 2017 10:59

I think I need to take a closer look...

@sudo-suhas sudo-suhas force-pushed the refactor_use_const_let branch 2 times, most recently from 040c794 to e9b34bc Compare September 4, 2017 06:45
@sudo-suhas
Copy link
Contributor Author

ping @LinusBorg. Any changes needed from my side?

@LinusBorg
Copy link
Contributor

Nope, was on vacation for 10 days, will do the merges this weekeend.

@LinusBorg LinusBorg merged commit 17ed63b into vuejs-templates:develop Sep 30, 2017
@sudo-suhas sudo-suhas deleted the refactor_use_const_let branch September 30, 2017 13:05
@sudo-suhas sudo-suhas mentioned this pull request Oct 1, 2017
Merged
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Oct 13, 2017
@sudo-suhas @frandiox
refactor: Use const/let instead of var with strict mode (vuejs-templa…
30ec94e 
…tes#801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg left review comments

Assignees
No one assigned
Labels
intend to implement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-suhas @LinusBorg