feat: Add async style compilation support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
force-pushed
the
feat/async-style-compilation
branch
from
ab490ff to
cbcf798
Compare
yyx990803
requested changes
May 28, 2018
lib/compileStyle.ts
Outdated
| @@ -73,6 +74,25 @@ export function compileStyle ( | |||
| code = result.css | |||
| outMap = result.map | |||
| } catch (e) { | |||
| if (/work with async plugins/i.test(e.message)) { | |||
There was a problem hiding this comment.
I don't think automatic detection like this is a good idea - the return value will change between an object and a Promise based on the plugins used and that can be confusing. I think it's more explicit to opt-into async mode.
znck
changed the title
yyx990803
requested changes
Jun 1, 2018
README.md
Outdated
| @@ -116,6 +116,11 @@ interface StyleCompileOptions { | |||
| map?: any | |||
| scoped?: boolean | |||
| trim?: boolean | |||
| sync?: boolean // Force sync compilation | |||
There was a problem hiding this comment.
This needs to be removed and add an entry for compileStyleAsync
yyx990803
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.