Skip to content

feat: add prettify option #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2019
Merged

feat: add prettify option #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d29e375
feat: add `formatCompiled` option
haoqunjiang Jan 1, 2019
2fe5cfd
chore: formatCompiled => prettify
haoqunjiang Jan 2, 2019
40a71dc
Merge branch 'master' into prettier
haoqunjiang Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ interface TemplateCompileOptions {
isProduction?: boolean // default: false
isFunctional?: boolean // default: false
optimizeSSR?: boolean // default: false

// Whether prettify compiled render function or not (development only)
// default: true
prettify?: boolean
}

interface TemplateCompileResult {
Expand Down
13 changes: 10 additions & 3 deletions lib/compileTemplate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import assetUrlsModule, {
} from './templateCompilerModules/assetUrl'
import srcsetModule from './templateCompilerModules/srcset'

const prettier = require('prettier')
const consolidate = require('consolidate')
const transpile = require('vue-template-es2015-compiler')

Expand All @@ -21,6 +20,7 @@ export interface TemplateCompileOptions {
isProduction?: boolean
isFunctional?: boolean
optimizeSSR?: boolean
prettify?: boolean
}

export interface TemplateCompileResult {
Expand Down Expand Up @@ -103,7 +103,8 @@ function actuallyCompile(
transformAssetUrls,
isProduction = process.env.NODE_ENV === 'production',
isFunctional = false,
optimizeSSR = false
optimizeSSR = false,
prettify = true
} = options

const compile =
Expand Down Expand Up @@ -163,7 +164,13 @@ function actuallyCompile(
// mark with stripped (this enables Vue to use correct runtime proxy
// detection)
code += `render._withStripped = true`
code = prettier.format(code, { semi: false, parser: 'babylon' })

if (prettify) {
code = require('prettier').format(code, {
semi: false,
parser: 'babylon'
})
}
}

return {
Expand Down