Skip to content

feat: implement ::-v-deep as a shadow piercing combinator #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2019
Merged

feat: implement ::-v-deep as a shadow piercing combinator #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a75d87e
feat: implement ::v-deep as a shadow piercing combinator
haoqunjiang Feb 2, 2019
a23f734
chore: rename ::v-deep to ::-v-deep to follow vendor prefix convention
haoqunjiang Feb 3, 2019
80b5a72
revert to ::v-deep
yyx990803 Feb 21, 2019
86c60a6
Update stylePluginScoped.spec.ts
yyx990803 Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/stylePlugins/scoped.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export default postcss.plugin('add-id', (options: any) => (root: Root) => {
selectors.each((selector: any) => {
let node: any = null

// find the last child node to insert attribute selector
selector.each((n: any) => {
// ">>>" combinator
// and /deep/ alias for >>>, since >>> doesn't work in SASS
Expand All @@ -35,6 +36,13 @@ export default postcss.plugin('add-id', (options: any) => (root: Root) => {
n.spaces.before = n.spaces.after = ''
return false
}

// in newer versions of sass, /deep/ support is also dropped, so add a ::v-deep alias
if (n.type === 'pseudo' && n.value === '::v-deep') {
n.value = n.spaces.before = n.spaces.after = ''
return false
}

if (n.type !== 'pseudo' && n.type !== 'combinator') {
node = n
}
Expand Down
6 changes: 6 additions & 0 deletions test/stylePluginScoped.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ h1 {
.foo div /deep/ .bar {
color: red;
}

.foo span ::v-deep .bar {
color: red;
}
`
})

Expand Down Expand Up @@ -107,6 +111,8 @@ h1 {
expect(style).toContain(`.foo p[v-scope-xxx] .bar {\n color: red;\n}`)
// /deep/ alias for >>>
expect(style).toContain(`.foo div[v-scope-xxx] .bar {\n color: red;\n}`)
// ::-v-deep alias for >>>
expect(style).toContain(`.foo span[v-scope-xxx] .bar {\n color: red;\n}`)
})

test('pseudo element', () => {
Expand Down