Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): using deep:true in SSR context #477

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 14, 2020

fix #473

I don't know what is causing this to happen, so I can't test this.

This should never happen because the watcher.value is still reactive but doesn't have __ob__

@pikax pikax requested a review from antfu August 14, 2020 08:09
@pikax
Copy link
Member Author

pikax commented Aug 14, 2020

Found the issue!

This is caused by SSR rendering.

Minimal example with nuxt: https://codesandbox.io/s/determined-ganguly-vfdei?file=/pages/index.vue

@pikax pikax changed the title fix(watch): check if __ob__ has value before addSub fix(watch): using deep:true in SSR context Aug 14, 2020
@pikax pikax merged commit d8cd30d into vuejs:master Aug 15, 2020
@pikax pikax deleted the fix/watch_when_ob_is_null branch August 15, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in data(): "TypeError: Cannot read property 'dep' of undefined" in beta9
2 participants