Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using symbol as a prop type throw error #10920

Closed
vaibhav11s opened this issue May 12, 2024 · 3 comments · Fixed by #10921
Closed

using symbol as a prop type throw error #10920

vaibhav11s opened this issue May 12, 2024 · 3 comments · Fixed by #10921
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem regression scope: compiler scope: types

Comments

@vaibhav11s
Copy link

Vue version

3.4.27

Link to minimal reproduction

https://play.vuejs.org/#eNqNU22L2zAM/ivCX9KDLoVtMMjSQjcK2+62dm3ZKOdj5BK1Sy+xg+10DaX/fbLdlxTasS/Glh9Jj6RHOzasqnBTI4tYrFOVVwY0mrqCIhGrPmdGczbgIi8rqQx8lGUFSyVLCMKefVjX4D0XXKRSaAOzxdf70QL6MGvKZ1l0At2Ur16wCe7OGPm8JsCOCwCDWxNB8Gn08DAOutby6CM8kfX7z9F0vgi42FvfuOfpERl6GCyrIjFIL4A4yzfuAuAi+WvsyEabpKiRCqGsnEFOjpaPrYxyk6V38LwKj1p4T6zlYXMNXf6eJxD3WrRYl3pHBS/zVbjWUlCDXcmcpZQoL1CNK5NTQziLfDPsX1IU8s8XZzOqRtcS5/Mb05cr9rXeWhtnE4Ua1QY5O/2ZRK2QSrTfo9k3V+7ps5RZXRD6H59T1LKoLUcP+1CLjGi3cI7tZyeNXKzmerQ1KPSxKEvUIvcOzxlJxfb4Vulnum/Ct86PJk9dPMqspdBLbZqmQhiKZoqpVBlJy19iGptcQiKarj0I6OWXECIgVV0K6pb2YYUCVZ7Scz4m4VKjUGT6nK+9Hjuws60NZrA/rMlpPw48J0pWOp5cDTU4roUTYQQWZZ9WhPfYROAr8ma3FL6iysYk3wyXucBDBndayoNBp7V8Wa5Joc0Pm4Fcjnw7nTvoD3yk0KV/9PdD7icK8X8buNtd5tgT0dsr8muDygqGhktTD1+/Y/u/qemHZg==

Steps to reproduce

happening in dev mode

What is expected?

not throw error

What is actually happening?

error is thrown

System Info

No response

Any additional comments?

In the given reproduction the error is getting thrown in all the version.

In my project I am using Nuxt 3.11.
and on vue3.4.26 the symbol key is working, and when upgraded to vue3.4.27, it starts breaking.
@jh-leong jh-leong mentioned this issue May 13, 2024
Merged
@jh-leong
Copy link
Member

Workaround: use symbol | string | number instead of keyof Record<...>. See playground.

@vaibhav11s
Copy link
Author

vaibhav11s commented May 13, 2024 •
edited
Loading

using the workaround wont give benefits of type inference.

my use-case
Screenshot 2024-05-13 at 13 09 59

@jh-leong
Copy link
Member

Oops, I misunderstood. You can separate keyof from Props to avoid runtime errors and maintain type inference. See playground.

@haoqunjiang haoqunjiang added scope: types scope: compiler has workaround A workaround has been found to avoid the problem 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. regression labels May 16, 2024
yyx990803 pushed a commit that referenced this issue Jun 7, 2024
@jh-leong
fix(compiler-sfc): improve type resolving for the keyof operator (#10921
293cf4e 
)

close #10920 
close #11002
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem regression scope: compiler scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-sfc): fix type inference issue with the keyof operator jh-leong/core
3 participants
@haoqunjiang @vaibhav11s @jh-leong