Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback slot content not rendered in nested component with slot #2461

Closed
07akioni opened this issue Oct 22, 2020 · 0 comments · Fixed by #2485
Closed

fallback slot content not rendered in nested component with slot #2461

07akioni opened this issue Oct 22, 2020 · 0 comments · Fixed by #2485
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working

Comments

@07akioni
Copy link
Contributor

Version

3.0.2

Reproduction link

https://codesandbox.io/s/vue3-nested-slot-fallback-bug-7n86x

Steps to reproduce

follow the link

image

In vue2 it works

https://codesandbox.io/s/vue2-nested-slot-fallback-bug-sn4pn

image

What is expected?

fallback content of inner is shown

What is actually happening?

not displayed
@LinusBorg LinusBorg added the 🐞 bug Something isn't working label Oct 23, 2020
@HcySunYang HcySunYang mentioned this issue Oct 26, 2020
Merged
@LinusBorg LinusBorg added the has PR A pull request has already been submitted to solve the issue label Oct 28, 2020
yyx990803 pushed a commit that referenced this issue Nov 26, 2020
@HcySunYang
fix(slots): should render fallback content when slot content contains…
ce4915d 
… no valid nodes (#2485)

fix #2347, fix #2461
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): only render valid slot content
2 participants
@LinusBorg @07akioni