Skip to content

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 15, 2022

Fix nuxt/nuxt#14845

It was introduced in #6489

Out of scope of this PR, but should we consider doing some unique normalization for it to reduce maintenance burden, or even directly change it to Set?

@antfu antfu added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Sep 15, 2022
@yyx990803 yyx990803 merged commit 57ffc3e into main Sep 27, 2022
@yyx990803 yyx990803 deleted the fix/duplicate-helper branch September 27, 2022 09:06
@yyx990803
Copy link
Member

I think I used an array just for consistency with other properties on RootNode, but I agree a Set would be better. Open to a PR to refactor it.

chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifier '_unref' has already been declared
2 participants