Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch multiple shallowRef & computed has a unnecessary trigger #9464

Closed
ShuZhong opened this issue Oct 23, 2023 · 2 comments · Fixed by #5912
Closed

watch multiple shallowRef & computed has a unnecessary trigger #9464

ShuZhong opened this issue Oct 23, 2023 · 2 comments · Fixed by #5912
Labels
has PR A pull request has already been submitted to solve the issue scope: reactivity

Comments

@ShuZhong
Copy link

Vue version

3.3.6

Link to minimal reproduction

https://play.vuejs.org/#eNqlVE1v2zAM/SuELk0Ax84HsEPgZF2HYtgO29D1NvXg2YztzpYESXYCBPnvo+QktbOg2NCLLPGRj9Qj5T37oFTYNsiWLLZYqyqxuOYCIM7Kdh1HbuUijnpYbFJdKgtVIvIVZ9ZwBgZtowgrayW1hT1o3ARgiqSq5PbB7VNZq8ZiFsA2sWkBB9hoWcMN5b7hgotUCmOhTaoGZ7By8aPZeGCek/mF8RJdEHrKMRqNYbU+koX+AzHMpvDeLcshQDRc+JpGPzvgKQDaPnkOl0FWGFYyH7VjGEMUwScpsyVYXeY5apiBLWscUsz/j2J6hWLxdop5cJSmo3LHxRU+bz+S3iVXbsYFIZmEtKCO05ma/UiAbOxR6L0bmIGoK5hzcQhgPp1OSeA46maGJoQFNDGUf1Pm4bORggbPh3PmuldWqL8pW1J9nC07Yof5rn/xNqsbDE72tMD09xX7s9k5G2ffNRrULXJ2xmyic7QdfP/jK+5ofwZrmTUVeb8CPiBp17gaO7e7RmRUds/PV/vZP4VS5I/mfmdRmNOlXKHO8+D9OaMX8PGVq7+UuwgXPo6UJRW7pzapE3WhYwcMSShHV2xhrTLLKEozQWEZVmWrQ4E2EqqObskt0o1wbZ9ksr6ljOE7+gcY2zeHaOrJLy23pCyR9C7u4r3ceqJRZKidLP+W9iKsn/oC+iv9WZTDH3Mzl20=

Steps to reproduce

Open browser console，see console.log output

What is expected?

watch([value2, value3], ([v2, v3]) => console.log(v2, v3) ) // Good: trigger 0 time

What is actually happening?

watch([value2, value3], ([v2, v3]) => console.log(v2, v3) ) // Bad: trigger 1 time

System Info

No response

Any additional comments?

No response
@sodatea
Copy link
Member

sodatea commented Oct 24, 2023

Could be solved by #5912

@sodatea sodatea added the has PR A pull request has already been submitted to solve the issue label Oct 24, 2023
@sodatea sodatea linked a pull request Oct 24, 2023 that will close this issue
feat(reactivity): more efficient reactivity system #5912
Merged
@johnsoncodehk johnsoncodehk mentioned this issue Oct 25, 2023
Merged
yyx990803 pushed a commit that referenced this issue Oct 27, 2023
@johnsoncodehk
feat(reactivity): more efficient reactivity system (#5912)
4a25e25 
fix #311, fix #1811, fix #6018, fix #7160, fix #8714, fix #9149, fix #9419, fix #9464
sxzz pushed a commit that referenced this issue Oct 27, 2023
@johnsoncodehk @sxzz
feat(reactivity): more efficient reactivity system (#5912)
16e06ca 
fix #311, fix #1811, fix #6018, fix #7160, fix #8714, fix #9149, fix #9419, fix #9464
@johnsoncodehk
Copy link
Member

Fixed by #5912

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has PR A pull request has already been submitted to solve the issue scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(reactivity): more efficient reactivity system johnsoncodehk/core
4 participants
@sodatea @pikax @johnsoncodehk @ShuZhong