Skip to content

fix(custom-element): avoid premature disconnection of MutationObserver when custom elements are moved #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

fix(custom-element): avoid premature disconnection of MutationObserver when custom elements are moved #10613

merged 3 commits into from
May 21, 2024

Conversation

baiwusanyu-c
Copy link
Member

close: #10610

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB (-1 B) 31.1 kB (+19 B)
vue.global.prod.js 148 kB 53.8 kB 48.1 kB (+4 B)

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.8 kB (+25 B)
overall 64.5 kB 24.9 kB 22.6 kB

@baiwusanyu-c baiwusanyu-c changed the title fix(custom-element): Avoid premature disconnection of MutationObserver when custom elements are moved fix(custom-element): avoid premature disconnection of MutationObserver when custom elements are moved Mar 29, 2024
@haoqunjiang haoqunjiang added the ready to merge The PR is ready to be merged. label May 21, 2024
@haoqunjiang haoqunjiang merged commit bbb5be2 into vuejs:main May 21, 2024
@haoqunjiang haoqunjiang changed the title fix(custom-element): avoid premature disconnection of MutationObserver when custom elements are moved fix(custom-element): disconnect MutationObserver in nextTick in case that custom elements are moved May 21, 2024
@haoqunjiang haoqunjiang changed the title fix(custom-element): disconnect MutationObserver in nextTick in case that custom elements are moved fix(custom-element): avoid premature disconnection of MutationObserver when custom elements are moved May 21, 2024
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@baiwusanyu-c @lynxlangya
fix(custom-element): disconnect MutationObserver in nextTick in case …
8e49853 
…that custom elements are moved (vuejs#10613)

Closes vuejs#10610
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/10610 branch August 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MutationObserver in defineCustomElement is disconnected if we move the custom element to another place, then lose attribute observation
2 participants
@baiwusanyu-c @haoqunjiang