Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/dts-test/defineCustomElement.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe('inject', () => {
})

describe('defineCustomElement using defineComponent return type', () => {
test('with emits', () => {
test('with object emits', () => {
const Comp1Vue = defineComponent({
props: {
a: String,
Expand All @@ -80,6 +80,23 @@ describe('defineCustomElement using defineComponent return type', () => {
const Comp = defineCustomElement(Comp1Vue)
expectType<VueElementConstructor>(Comp)

expectType<string | undefined>(new Comp().a)
const instance = new Comp()
expectType<string | undefined>(instance.a)
instance.a = ''
})

test('with array emits', () => {
const Comp1Vue = defineComponent({
props: {
a: Number,
},
emits: ['click'],
})
const Comp = defineCustomElement(Comp1Vue)
expectType<VueElementConstructor>(Comp)

const instance = new Comp()
expectType<number | undefined>(instance.a)
instance.a = 42
})
})
14 changes: 10 additions & 4 deletions packages/runtime-dom/src/apiCustomElement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,17 @@ export function defineCustomElement<
>,
): VueElementConstructor<ResolvedProps>

// overload 5: defining a custom element from the returned value of
// overload 3: defining a custom element from the returned value of
// `defineComponent`
export function defineCustomElement<P>(
options: DefineComponent<P, any, any, any>,
): VueElementConstructor<ExtractPropTypes<P>>
export function defineCustomElement<
T extends DefineComponent<any, any, any, any>,
>(
options: T,
): VueElementConstructor<
T extends DefineComponent<infer P, any, any, any>
? ExtractPropTypes<P>
: unknown
>

/*! #__NO_SIDE_EFFECTS__ */
export function defineCustomElement(
Expand Down