dx(useTemplateRef): warn when declaring with the same key #11462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring
useTemplateRef
with the same key multiple times results in aTypeError: Cannot redefine property: xxx
at runtime, see playgroundThere's another issue: in dev mode, the
useTemplateRef
returned value isreadonly
:When a variable declared with
useTemplateRef
has the same name as a template ref, a readonly warning appears, see playground.To avoid this issue, it seems that we need to check if
setupState[ref]
isreadonly
before setting its value every time inrendererTemplateRef.ts
.I'm not sure if this is worth it. Maybe we should only limit the
readonly
return type at the type level?