Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions packages/runtime-core/__tests__/components/KeepAlive.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1121,4 +1121,56 @@ describe('KeepAlive', () => {
expect(mountedB).toHaveBeenCalledTimes(1)
expect(unmountedB).toHaveBeenCalledTimes(0)
})

// #11717
test('remove component from include then switching child', async () => {
const About = {
name: 'About',
render() {
return h('h1', 'About')
},
}
const mountedHome = vi.fn()
const unmountedHome = vi.fn()
const activatedHome = vi.fn()
const deactivatedHome = vi.fn()
const Home = {
name: 'Home',
setup() {
onMounted(mountedHome)
onUnmounted(unmountedHome)
onDeactivated(deactivatedHome)
onActivated(activatedHome)
return () => {
h('h1', 'Home')
}
},
}
const activeViewName = ref('Home')
const cacheList = reactive(['Home'])
const App = createApp({
setup() {
return () => {
return [
h(
KeepAlive,
{
include: cacheList,
},
[activeViewName.value === 'Home' ? h(Home) : h(About)],
),
]
}
},
})
App.mount(nodeOps.createElement('div'))
expect(mountedHome).toHaveBeenCalledTimes(1)
expect(activatedHome).toHaveBeenCalledTimes(1)
cacheList.splice(0, 1)
await nextTick()
activeViewName.value = 'About'
await nextTick()
expect(deactivatedHome).toHaveBeenCalledTimes(0)
expect(unmountedHome).toHaveBeenCalledTimes(1)
})
})
2 changes: 2 additions & 0 deletions packages/runtime-core/src/components/KeepAlive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,8 @@ const KeepAliveImpl: ComponentOptions = {
(include && (!name || !matches(include, name))) ||
(exclude && name && matches(exclude, name))
) {
// #11717
vnode.shapeFlag &= ~ShapeFlags.COMPONENT_SHOULD_KEEP_ALIVE
current = vnode
return rawVNode
}
Expand Down