Skip to content

fix(compiler-ssr): handle newlines at the beginning of textarea content #11874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(compiler-ssr): handle newlines at the beginning of textarea content #11874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d41a593
fix(compiler-ssr): handle newlines at the beginning of textarea content
linzhe141 Sep 10, 2024
85dca3b
chore: update test
linzhe141 Sep 10, 2024
67d0986
chore: update test
linzhe141 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/compiler-ssr/src/transforms/ssrTransformElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ export const ssrTransformElement: NodeTransform = (node, context) => {
createSimpleExpression(`"value" in ${tempId}`, false),
createSimpleExpression(`${tempId}.value`, false),
createSimpleExpression(
existingText ? existingText.content : ``,
existingText
? `${existingText.content[0] === '\n' ? '\n' : ''}${existingText.content}`
: ``,
true,
),
false,
Expand Down
8 changes: 8 additions & 0 deletions packages/runtime-core/__tests__/hydration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,6 +1908,14 @@ describe('SSR hydration', () => {
expect(`Hydration attribute mismatch`).toHaveBeenWarned()
})

test('<textarea> with newlines at the beginning', async () => {
const html = await renderToString(
createSSRApp({ template: '<textarea>\n</textarea>' }),
)
mountWithHydration(html, () => h('textarea', null, '\n'))
expect(`Hydration text content mismatch`).not.toHaveBeenWarned()
})

test('boolean attr handling', () => {
mountWithHydration(`<input />`, () => h('input', { readonly: false }))
expect(`Hydration attribute mismatch`).not.toHaveBeenWarned()
Expand Down