Skip to content

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/compiler-sfc/__tests__/compileScript.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ describe('SFC compile <script setup>', () => {
expect(() =>
compile(`<script setup>
let bar = 1
const model = defineModel({
defineModel({
default: () => bar
})
</script>`),
Expand All @@ -1017,7 +1017,7 @@ describe('SFC compile <script setup>', () => {
expect(() =>
compile(`<script setup>
const bar = 1
const model = defineModel({
defineModel({
default: () => bar
})
</script>`),
Expand All @@ -1027,7 +1027,7 @@ describe('SFC compile <script setup>', () => {
expect(() =>
compile(`<script setup>
let bar = 1
const model = defineModel({
defineModel({
get: () => bar,
set: () => bar
})
Expand Down
12 changes: 0 additions & 12 deletions packages/compiler-sfc/__tests__/compileScript/defineModel.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,16 +269,4 @@ describe('defineModel()', () => {
modelValue: BindingTypes.SETUP_REF,
})
})

test('error when defineModel is not assigned to a variable', () => {
expect(() =>
compile(`
<script setup>
defineModel()
</script>
`),
).toThrow(
'defineModel() must be assigned to a variable. For example: const model = defineModel()',
)
})
})
7 changes: 0 additions & 7 deletions packages/compiler-sfc/src/script/defineModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ export function processDefineModel(
return false
}

if (!declId) {
ctx.error(
'defineModel() must be assigned to a variable. For example: const model = defineModel()',
node,
)
}

ctx.hasDefineModelCall = true

const type =
Expand Down