Skip to content

chore: update side effect annotations to use standardized format #13839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

chore: update side effect annotations to use standardized format #13839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-core/src/apiAsyncComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export interface AsyncComponentOptions<T = any> {
export const isAsyncWrapper = (i: ComponentInternalInstance | VNode): boolean =>
!!(i.type as ComponentOptions).__asyncLoader

/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
export function defineAsyncComponent<
T extends Component = { new (): ComponentPublicInstance },
>(source: AsyncComponentLoader<T> | AsyncComponentOptions<T>): T {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/apiDefineComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export function defineComponent<
>

// implementation, close to no-op
/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
export function defineComponent(
options: unknown,
extraOptions?: ComponentOptions,
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const devtoolsComponentRemoved = (

type DevtoolsComponentHook = (component: ComponentInternalInstance) => void

/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
function createDevtoolsComponentHook(
hook: DevtoolsHooks,
): DevtoolsComponentHook {
Expand Down
4 changes: 2 additions & 2 deletions packages/runtime-dom/src/apiCustomElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export function defineCustomElement<
T extends DefineComponent<infer P, any, any, any> ? P : unknown
>

/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
export function defineCustomElement(
options: any,
extraOptions?: ComponentOptions,
Expand All @@ -184,7 +184,7 @@ export function defineCustomElement(
return VueCustomElement
}

/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
export const defineSSRCustomElement = ((
options: any,
extraOptions?: ComponentOptions,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/makeMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* So that rollup can tree-shake them if necessary.
*/

/*! #__NO_SIDE_EFFECTS__ */
/*@__NO_SIDE_EFFECTS__*/
export function makeMap(str: string): (key: string) => boolean {
const map = Object.create(null)
for (const key of str.split(',')) map[key] = 1
Expand Down
Loading