Skip to content

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Oct 13, 2025

fix #13980

Summary by CodeRabbit

  • Documentation
    • Removed an outdated table entry that referenced the v-bind.prop modifier in the Vue compatibility docs.
    • Clarified current behavior by eliminating redundant/obsolete information related to that modifier.
    • This is a documentation cleanup only; no functional changes were made and existing usage remains unaffected.
    • No action required for users; the docs are now more accurate and easier to scan.

Copy link

coderabbitai bot commented Oct 13, 2025

Walkthrough

The documentation in packages/vue-compat/README.md was updated by removing a table row referencing the COMPILER_V_BIND_PROP flag that claimed the v-bind.prop modifier was removed. No code or behavior changes were made.

Changes

Cohort / File(s) Summary
Documentation update
packages/vue-compat/README.md
Removed the README table row for COMPILER_V_BIND_PROP that incorrectly stated the removal of the v-bind.prop modifier; no other content changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ready to merge

Poem

A bunny nibbles docs so neat,
Snips one row, a tidy feat.
No props removed, the record clear—
Hop, hop! Accuracy is here.
With ears up high and carrots bright,
We keep the pages trimmed just right. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues Check ✅ Passed The pull request deletes the misleading COMPILER_V_BIND_PROP entry from the vue-compat README, directly addressing the linked issue’s requirement to remove or correct the inaccurate reference to the v-bind.prop modifier and thereby ensuring the compat flags list is accurate. This change aligns with the objective of fixing the documentation without altering any functional code.
Out of Scope Changes Check ✅ Passed The PR is limited to removing a single row in packages/vue-compat/README.md and does not include any unrelated code or files, confirming that all modifications are in scope of the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title succinctly indicates that the documentation entry for COMPILER_V_BIND_PROP is being removed, directly matching the change in the README and the PR’s intent. It is concise, clear, and focused on the primary update.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/docs/removeCompile_v_bind_prop

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 102 kB 38.6 kB 34.8 kB
vue.global.prod.js 160 kB 58.7 kB 52.2 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.7 kB 18.3 kB 16.7 kB
createApp 54.7 kB 21.3 kB 19.5 kB
createSSRApp 58.9 kB 23 kB 21 kB
defineCustomElement 60 kB 23 kB 21 kB
overall 68.8 kB 26.5 kB 24.2 kB

Copy link

pkg-pr-new bot commented Oct 13, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13986

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13986

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13986

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13986

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13986

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13986

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13986

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13986

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13986

vue

npm i https://pkg.pr.new/vue@13986

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13986

commit: 3530223

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Oct 13, 2025
@edison1105 edison1105 changed the title chore: remove COMPILER_V_BIND_PROP docs: remove COMPILER_V_BIND_PROP Oct 13, 2025
@edison1105 edison1105 merged commit 45547e6 into main Oct 13, 2025
16 checks passed
@edison1105 edison1105 deleted the edison/docs/removeCompile_v_bind_prop branch October 13, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migration build: COMPILER_V_BIND_PROP incorrectly implies v-bind:foo.prop was removed

1 participant