Skip to content

fix(apiWatch): callback not called when using flush:sync #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

fix(apiWatch): callback not called when using flush:sync #1633

merged 1 commit into from
Jul 19, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Jul 19, 2020 •
edited
Loading

Fix #1636

This 341b30c broke the flush:sync

the job is not being called anymore, the invoke was calling the getter (aka the cb)

@yyx990803 yyx990803 merged commit 8facaef into vuejs:master Jul 19, 2020
@pikax pikax deleted the fix/watch_callback_not_called_with_using_sync branch August 15, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sync watch not trigger

2 participants

@pikax @yyx990803