fix(runtime-core): support object syntax for class in templates #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanf
force-pushed
the
fix-class-object-syntax
branch
from
c0c53ef to
1c8d24f
Compare
|
Yeah, that's correct. I dropped the class optimization part because it relies on full AST analysis and won't be consistent between browser/non-browser builds. |
|
Hey @xanf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
sxzz
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic in
vnode.tsdoes not normalize classes for templates, because ofPatchFlags.CLASSset on compiled VNode.Unfortunately, at least for browser build,
PatchFlags.CLASSdoes not mean that any kind of compile-time optimization was applied to class (I'm not 100% sure, but it seems that it is handled byprocessExpressioncode path, which is not taken in a browser)It results in
[object Object]being displayed as a class name when:class = { foo: smthng, bar: smthng }syntax is used.This PR removes that extra check and adds an integration test for this scenario.