chore(compiler-core,typings): improve typings #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
reviewed
Oct 12, 2019
packages/compiler-core/src/utils.ts
Outdated
There was a problem hiding this comment.
Suggested change
| export const parseJS: typeof parse = (code: string, options: acorn.Options) => { | |
| export const parseJS: typeof parse = (code, options) => { |
We can remove explicit types as types can be inferred from typeof parse.
There was a problem hiding this comment.
@znck Totally right! Made the changes.
runofthemillgeek
force-pushed
the
chore/compiler-core-improve-typings-parsejs
branch
from
ecf4d37 to
84779cd
Compare
znck
approved these changes
Oct 12, 2019
|
Hey @sangeeth96, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
sxzz
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, since
acorn.parsecompatible options are only being accepted. Probably need a custom interface instead.CC: @znck