Skip to content

test: remove deprecated usage of waitFor #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: remove deprecated usage of waitFor #3971

wants to merge 1 commit into from

Conversation

neal2018
Copy link

Hey, according to puppeteer/puppeteer#6214, waitFor is being deprecated and should be replaced with waitForSelector, waitForFunction, or other waitForX.

This PR replaces all waitFor with corresponding waitForX.

@posva posva changed the title fix(test): remove waitFor in tests test: remove deprecated usage of waitFor Jun 17, 2021
@leopiccionia leopiccionia mentioned this pull request Jun 30, 2021
Merged
@yyx990803
Copy link
Member

Thanks for the PR - this is addressed in #4019 which also bumps puppeteer.

@yyx990803 yyx990803 closed this Jul 1, 2021
@neal2018 neal2018 deleted the fix/waitFor branch July 1, 2021 19:18
@neal2018
Copy link
Author

neal2018 commented Jul 1, 2021

Thanks for the PR - this is addressed in #4019 which also bumps puppeteer.

Hey, thanks for the respond.
I am just wondering how to get the PR merged instead of being shadowed by another later PR? Do I need to directly notify someone to review? I can not find any relevant information in the contribution guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neal2018 @yyx990803