Skip to content

chore(types): remove unnecessary type assertions #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021
Merged

chore(types): remove unnecessary type assertions #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-ssr/src/transforms/ssrTransformSuspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function ssrTransformSuspense(
return () => {
if (node.children.length) {
const wipEntry: WIPEntry = {
slotsExp: null as any,
slotsExp: null!, // to be immediately set
wipSlots: []
}
wipMap.set(node, wipEntry)
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ export function createComponentInstance(
emitsOptions: normalizeEmitsOptions(type, appContext),

// emit
emit: null as any, // to be set immediately
emit: null!, // to be set immediately
emitted: null,

// props default value
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/componentOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ export function applyOptions(instance: ComponentInternalInstance) {
`Plain object usage is no longer supported.`
)
}
const data = (dataOptions as any).call(publicThis, publicThis)
const data = dataOptions.call(publicThis, publicThis)
if (__DEV__ && isPromise(data)) {
warn(
`data() returned a Promise - note data() cannot be async; If you ` +
Expand Down
3 changes: 1 addition & 2 deletions packages/runtime-dom/src/directives/vOn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ export const withKeys = (fn: Function, modifiers: string[]) => {
compatUtils.isCompatEnabled(DeprecationTypes.CONFIG_KEY_CODES, instance)
) {
if (instance) {
globalKeyCodes = (instance.appContext.config as any as LegacyConfig)
.keyCodes
globalKeyCodes = (instance.appContext.config as LegacyConfig).keyCodes
}
}
if (__DEV__ && modifiers.some(m => /^\d+$/.test(m))) {
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/__tests__/e2eUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function setupPuppeteer() {

page.on('console', e => {
if (e.type() === 'error') {
const err = e.args()[0] as any
const err = e.args()[0]
console.error(
`Error from Puppeteer-loaded page:\n`,
err._remoteObject.description
Expand Down