-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
chore: issues forms #5145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: issues forms #5145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea but I wonder if GitHub issues forms are still ready for us because they are lacking some i18n integration and a lot of our users use the Chinese version
required: true | ||
- type: textarea | ||
id: system-info | ||
attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be optional as it's not relevant for most issues in vue and it's annoying for users to do
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Migrate to issues forms. See playground at https://github.com/patak-dev/vue-issues-forms
This PR doesn't change the descriptions of each field. We should remove references to Vue 2 bugs here, and maybe point users to StackBlitz instead of CodeSandbox. I can modify it, or feel free to change the texts before merging.
Differences with https://new-issue.vuejs.org equivalent using issues forms:
There aren't conditional fields. A project could create one .yml issue form for each language and issue type and let them users choose (in the same way they choose if something is a Bug Report or a Feature Request)
Instead of the version combo box, following how Vite bug reports works we are asking this info directly with the system info asking users to run
envinfo
in their projectsNote: A version combo box could be done by each repo editing the yml to add the tag during release in each project.
Issues Forms doesn't work on mobile (this could count as a feature, uses shouldn't use mobile to report an issue
In Vite issues we include a series of required checkboxes that users need to tick before being able to submit. For Vitepress for example they look like
This is good to reinforce some checks that were described in the form description. The problem with these required checkboxes is that there isn't a way to avoid showing them in the final issue so the final issue is a bit more cluttered.