Skip to content

fix(effect): optimize effect trigger #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(effect): optimize effect trigger #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9821998
fix(effect): optimize effect trigger
guaijie Feb 21, 2020
67b7244
Update baseHandlers.ts
guaijie Feb 21, 2020
c1f4077
Update effect.ts
guaijie Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/reactivity/src/baseHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ function createSetter(isReadonly = false, shallow = false) {
}
} else {
if (!hadKey) {
trigger(target, TriggerOpTypes.ADD, key)
trigger(target, TriggerOpTypes.ADD, key, { newValue: value })
} else if (hasChanged(value, oldValue)) {
trigger(target, TriggerOpTypes.SET, key)
trigger(target, TriggerOpTypes.SET, key, { newValue: value })
}
}
}
Expand Down
12 changes: 10 additions & 2 deletions packages/reactivity/src/effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,20 @@ export function trigger(
}
const effects = new Set<ReactiveEffect>()
const computedRunners = new Set<ReactiveEffect>()
if (type === TriggerOpTypes.CLEAR || (key === 'length' && isArray(target))) {
if (type === TriggerOpTypes.CLEAR) {
// collection being cleared or Array length mutation
// trigger all effects for target
depsMap.forEach(dep => {
depsMap.forEach((dep, i) => {
addRunners(effects, computedRunners, dep)
})
} else if (key === 'length' && isArray(target)) {
const newValue = extraInfo.newValue
const startIndex: number = (newValue as number) || 0
depsMap.forEach((dep, i) => {
if (i >= startIndex || i === 'length') {
addRunners(effects, computedRunners, dep)
}
})
} else {
// schedule runs for SET | ADD | DELETE
if (key !== void 0) {
Expand Down