Skip to content

Conversation

LinusBorg
Copy link
Member

Just to make Eslint in VSCode happy when working in these files.

@LinusBorg LinusBorg added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Feb 13, 2023
@sxzz
Copy link
Member

sxzz commented Feb 22, 2023

no-undef rules doesn't seems to be enabled, so maybe we don't need node env.

I've already submitted a PR #7687 before

@LinusBorg
Copy link
Member Author

Oh, totally missed that, sorry!

@skirtles-code
Copy link
Contributor

Is this PR still needed? The config for ESLint has changed significantly since this PR was first opened.

@yyx990803
Copy link
Member

Closing as stale. Also the scripts are now esm and don't rely on any Node globals anymore.

@yyx990803 yyx990803 closed this Apr 29, 2024
@edison1105 edison1105 deleted the linusborg/fix-eslint-config-node branch October 21, 2024 07:37
@edison1105 edison1105 restored the linusborg/fix-eslint-config-node branch October 21, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

4 participants