Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable node env support in eslint for script&config files #7690

Closed
wants to merge 1 commit into from

Conversation

LinusBorg
Copy link
Member

Just to make Eslint in VSCode happy when working in these files.

@LinusBorg LinusBorg added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Feb 13, 2023
@sxzz
Copy link
Member

sxzz commented Feb 22, 2023

no-undef rules doesn't seems to be enabled, so maybe we don't need node env.

I've already submitted a PR #7687 before

@LinusBorg
Copy link
Member Author

Oh, totally missed that, sorry!

@skirtles-code
Copy link
Contributor

Is this PR still needed? The config for ESLint has changed significantly since this PR was first opened.

@yyx990803
Copy link
Member

Closing as stale. Also the scripts are now esm and don't rely on any Node globals anymore.

@yyx990803 yyx990803 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

None yet

4 participants