fix(hydration): Use decodeHtml when vnode is of text type #7776
+67
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
suggested changes
Feb 22, 2023
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
baiwusanyu-c
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
edison1105
reviewed
Jul 14, 2023
Size ReportBundles
Usages
|
Justineo
reviewed
Sep 15, 2023
|
take a closer look at ##7775.
|
# Conflicts: # packages/runtime-core/src/hydration.ts
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
# Conflicts: # packages/runtime-core/src/hydration.ts
baiwusanyu-c
force-pushed
the
bwsy/fix/hydrationText
branch
from
7be8642 to
9e9e1bf
Compare
edison1105
reviewed
Aug 27, 2024
| `\n - expected on client: ${JSON.stringify(vnode.children)}`, | ||
| ) | ||
| ;(node as Text).data = vnode.children as string | ||
| let dataContent = (node as Text).data.replace(/[\t\r\n\f ]+/g, '') |
There was a problem hiding this comment.
Only \r or \r\n would actually cause a mismatch. \t\f and blank will not
# Conflicts: # packages/runtime-core/src/hydration.ts
# Conflicts: # packages/runtime-core/src/hydration.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #7775
close: #9229