Skip to content

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2024
Merged

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c18eb20
refactor(runtime-core): prevent users from manually calling lifecycle…
Alfred-Skyblue Jul 6, 2023
024ee26
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Jul 9, 2023
34813d7
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Jul 17, 2023
2dc5fe1
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Aug 14, 2023
00a2e89
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Oct 19, 2023
c10a02e
chore: use `if` instead of `&&`
Alfred-Skyblue Oct 25, 2023
92093fc
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Nov 9, 2023
2ddaf12
Merge branch 'main' into fix-apiLifecylce
Alfred-Skyblue Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/runtime-core/src/apiLifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,15 @@ export function injectHook(

export const createHook =
<T extends Function = () => any>(lifecycle: LifecycleHooks) =>
(hook: T, target: ComponentInternalInstance | null = currentInstance) =>
(hook: T, target: ComponentInternalInstance | null = currentInstance) => {
// post-create lifecycle registrations are noops during SSR (except for serverPrefetch)
(!isInSSRComponentSetup || lifecycle === LifecycleHooks.SERVER_PREFETCH) &&
injectHook(lifecycle, (...args: unknown[]) => hook(...args), target)
if (
!isInSSRComponentSetup ||
lifecycle === LifecycleHooks.SERVER_PREFETCH
) {
injectHook(lifecycle, (...args: unknown[]) => hook(...args), target)
}
}

export const onBeforeMount = createHook(LifecycleHooks.BEFORE_MOUNT)
export const onMounted = createHook(LifecycleHooks.MOUNTED)
Expand Down