Skip to content

chore(deps): update test (major) #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2023
Merged

chore(deps): update test (major) #9148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08166f5
chore(deps): update test
renovate[bot] Sep 6, 2023
59ad21b
fix: e2e
sxzz Sep 6, 2023
916b15e
test: new headless mode
sxzz Sep 6, 2023
4f143d0
ci: fix
sxzz Sep 6, 2023
5202731
fix: install puppeteer
sxzz Sep 6, 2023
bd62c69
refactor: simplify
sxzz Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Setup cache for Chromium binary
uses: actions/cache@v3
with:
path: ~/.cache/puppeteer/chrome
path: ~/.cache/puppeteer
key: chromium-${{ hashFiles('pnpm-lock.yaml') }}

- name: Install pnpm
Expand All @@ -80,6 +80,7 @@ jobs:
cache: 'pnpm'

- run: pnpm install
- run: node node_modules/puppeteer/install.js

- name: Run e2e tests
run: pnpm run test-e2e
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"eslint-plugin-jest": "^27.2.1",
"estree-walker": "^2.0.2",
"execa": "^4.0.2",
"jsdom": "^21.1.0",
"jsdom": "^22.1.0",
"lint-staged": "^14.0.1",
"lodash": "^4.17.15",
"magic-string": "^0.30.0",
Expand All @@ -89,7 +89,7 @@
"prettier": "^3.0.1",
"pretty-bytes": "^6.1.1",
"pug": "^3.0.1",
"puppeteer": "~19.6.0",
"puppeteer": "~21.1.1",
"rollup": "^3.26.0",
"rollup-plugin-dts": "^5.3.0",
"rollup-plugin-esbuild": "^5.0.0",
Expand Down
72 changes: 36 additions & 36 deletions packages/vue/__tests__/e2e/Transition.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,12 +295,12 @@ describe('e2e: Transition', () => {
<div id="container">
<transition
name="test"
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy"
@before-leave="beforeLeaveSpy"
@leave="onLeaveSpy"
@after-leave="afterLeaveSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()"
@before-leave="beforeLeaveSpy()"
@leave="onLeaveSpy()"
@after-leave="afterLeaveSpy()">
<div v-if="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -496,7 +496,7 @@ describe('e2e: Transition', () => {
<div id="container">
<transition
name="test"
@enter-cancelled="enterCancelledSpy">
@enter-cancelled="enterCancelledSpy()">
<div v-if="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -666,15 +666,15 @@ describe('e2e: Transition', () => {
appear-from-class="test-appear-from"
appear-to-class="test-appear-to"
appear-active-class="test-appear-active"
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy"
@before-leave="beforeLeaveSpy"
@leave="onLeaveSpy"
@after-leave="afterLeaveSpy"
@before-appear="beforeAppearSpy"
@appear="onAppearSpy"
@after-appear="afterAppearSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()"
@before-leave="beforeLeaveSpy()"
@leave="onLeaveSpy()"
@after-leave="afterLeaveSpy()"
@before-appear="beforeAppearSpy()"
@appear="onAppearSpy()"
@after-appear="afterAppearSpy()">
<div v-if="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -802,12 +802,12 @@ describe('e2e: Transition', () => {
<transition
:css="false"
name="test"
@before-enter="onBeforeEnterSpy"
@enter="onEnterSpy"
@after-enter="onAfterEnterSpy"
@before-leave="onBeforeLeaveSpy"
@leave="onLeaveSpy"
@after-leave="onAfterLeaveSpy">
@before-enter="onBeforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="onAfterEnterSpy()"
@before-leave="onBeforeLeaveSpy()"
@leave="onLeaveSpy()"
@after-leave="onAfterLeaveSpy()">
<div v-if="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -1233,7 +1233,7 @@ describe('e2e: Transition', () => {
createApp({
template: `
<div id="container">
<transition @enter="onEnterSpy" @leave="onLeaveSpy">
<transition @enter="onEnterSpy()" @leave="onLeaveSpy()">
<Suspense>
<Comp v-if="toggle" class="test">content</Comp>
</Suspense>
Expand Down Expand Up @@ -1592,12 +1592,12 @@ describe('e2e: Transition', () => {
<div id="container">
<transition
name="test"
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy"
@before-leave="beforeLeaveSpy"
@leave="onLeaveSpy"
@after-leave="afterLeaveSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()"
@before-leave="beforeLeaveSpy()"
@leave="onLeaveSpy()"
@after-leave="afterLeaveSpy()">
<div v-show="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -1678,7 +1678,7 @@ describe('e2e: Transition', () => {
createApp({
template: `
<div id="container">
<transition name="test" @leave-cancelled="onLeaveCancelledSpy">
<transition name="test" @leave-cancelled="onLeaveCancelledSpy()">
<div v-show="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -1750,9 +1750,9 @@ describe('e2e: Transition', () => {
appear-from-class="test-appear-from"
appear-to-class="test-appear-to"
appear-active-class="test-appear-active"
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()">
<div v-show="toggle" class="test">content</div>
</transition>
</div>
Expand Down Expand Up @@ -1854,9 +1854,9 @@ describe('e2e: Transition', () => {
<transition
name="test"
appear
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()">
<div v-show="toggle" class="test">content</div>
</transition>
</div>
Expand Down
18 changes: 9 additions & 9 deletions packages/vue/__tests__/e2e/TransitionGroup.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,15 +400,15 @@ describe('e2e: TransitionGroup', () => {
appear-from-class="test-appear-from"
appear-to-class="test-appear-to"
appear-active-class="test-appear-active"
@before-enter="beforeEnterSpy"
@enter="onEnterSpy"
@after-enter="afterEnterSpy"
@before-leave="beforeLeaveSpy"
@leave="onLeaveSpy"
@after-leave="afterLeaveSpy"
@before-appear="beforeAppearSpy"
@appear="onAppearSpy"
@after-appear="afterAppearSpy">
@before-enter="beforeEnterSpy()"
@enter="onEnterSpy()"
@after-enter="afterEnterSpy()"
@before-leave="beforeLeaveSpy()"
@leave="onLeaveSpy()"
@after-leave="afterLeaveSpy()"
@before-appear="beforeAppearSpy()"
@appear="onAppearSpy()"
@after-appear="afterAppearSpy()">
<div v-for="item in items" :key="item" class="test">{{item}}</div>
</transition-group>
</div>
Expand Down
14 changes: 10 additions & 4 deletions packages/vue/__tests__/e2e/e2eUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import puppeteer, { Browser, Page, ClickOptions } from 'puppeteer'
import puppeteer, {
Browser,
Page,
ClickOptions,
PuppeteerLaunchOptions
} from 'puppeteer'

export const E2E_TIMEOUT = 30 * 1000

const puppeteerOptions = process.env.CI
? { args: ['--no-sandbox', '--disable-setuid-sandbox'] }
: {}
const puppeteerOptions: PuppeteerLaunchOptions = {
args: process.env.CI ? ['--no-sandbox', '--disable-setuid-sandbox'] : [],
headless: 'new'
}

const maxTries = 30
export const timeout = (n: number) => new Promise(r => setTimeout(r, n))
Expand Down
Loading