Skip to content

perf: exclude transpiled prompts code #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sapphi-red
Copy link
Contributor

Since this package supports Node 14+, the transpiled prompts code is not used.
https://github.com/terkelg/prompts/blob/a0c1777ae86d04e46cb42eb3af69ca74ae5d79e2/index.js#L11-L14
This PR removes that from bundle.

before after diff
gz 53,746B 39,690B -14,056B (-26.2%)
node_modules 319,900B 232,067B -87,833B (-27.5%)

@sapphi-red sapphi-red force-pushed the perf/exclude-transpiled-prompts-code branch from 2ffd199 to 14b6667 Compare July 11, 2022 15:42
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Never thought about that!

@haoqunjiang haoqunjiang merged commit e50e5d8 into vuejs:main Jul 12, 2022
@sapphi-red sapphi-red deleted the perf/exclude-transpiled-prompts-code branch July 12, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants