Skip to content

Update base.css #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update base.css #166

wants to merge 1 commit into from

Conversation

TrumanGao
Copy link

No description provided.

haoqunjiang
haoqunjiang reviewed Oct 8, 2022
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate why this change is necessary?

@TrumanGao
Copy link
Author

Could you elaborate why this change is necessary?

In some third-party dependencies (e.g. monaco-editor), the offsets of some positioned elements are not relative to their parent nodes but their ancestor nodes, cuz their parent nodes have no position attribute. Therefor, the original code may lead to certain unexpected offsets.

haoqunjiang
haoqunjiang requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
But this change breaks the styles of the landing page. We need to fix that before removing the global reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrumanGao @haoqunjiang