Skip to content

Conversation

btea
Copy link
Collaborator

@btea btea commented Nov 11, 2023

fix #370

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btea You need to rebase the PR, otherwise LGTM

@btea
Copy link
Collaborator Author

btea commented Nov 11, 2023

Sorry, I don't know how to rebase in this case, can you give me a hint? Thanks! 🤦‍♂️

@cexbrayat
Copy link
Member

I suppose you can do (assuming upstream is the vuejs/create-vue repo):

git checkout fix/component-ts-error
git fetch upstream
git rebase upstream/v2
# solve conflicts
git rebase continue
git push origin fix/component-ts-error --force

Does that help?

@btea btea force-pushed the fix/component-ts-error branch from d294b32 to 56aa7f0 Compare November 11, 2023 09:53
@btea
Copy link
Collaborator Author

btea commented Nov 11, 2023

@cexbrayat It has been solved, thank you very much! 👍

@cexbrayat cexbrayat merged commit affdd3e into vuejs:v2 Nov 11, 2023
@btea btea deleted the fix/component-ts-error branch November 11, 2023 12:10
@getr00t
Copy link

getr00t commented Nov 11, 2023

Why do I build the project and nothing changes? Still getting error, same bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants