Skip to content

fix: use vite dev during e2e dev #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: use vite dev during e2e dev #39

wants to merge 2 commits into from

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Jan 24, 2022

No description provided.

@haoqunjiang
Copy link
Member

This makes some sense as all browsers that Cypress supports are modern browsers.
🤔 But on the other hand, unlike webpack, vite dev and vite build outputs differ greatly. Unit tests can't cover these differences.
So I would prefer to use E2E tests to make sure the build works correctly. Speed isn't much of a concern here.

@haoqunjiang haoqunjiang mentioned this pull request Oct 19, 2022
Merged
@haoqunjiang
Copy link
Member

Superseded by #183
We now have a test:e2e:dev command to use the dev server and run the tests interactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akryum @haoqunjiang