feat: eslint plugin playwright #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one @georgi-mateev |
cexbrayat
requested changes
Jan 27, 2024
utils/renderEslint.ts
Outdated
| @@ -35,6 +35,11 @@ export default function renderEslint( | |||
| additionalDependencies['eslint-plugin-cypress'] = eslintDeps['eslint-plugin-cypress'] | |||
| } | |||
|
|
|||
| if (needsPlaywright) { | |||
| additionalConfig.extends = ['plugin:playwright/recommended'] | |||
There was a problem hiding this comment.
shouldn't the plugin apply only the Playwright files (as done for Cypress above)?
There was a problem hiding this comment.
Yes, ESLint will apply the rules defined in the root of your configuration to all files in your project (which is not ideal).
@georgi-mateev Can you target e2e folder - something like files: ['e2e/**/*.{js,ts,jsx,tsx}']?
|
@cexbrayat, @Yordan-Ramchev Thanks for the feedback and the help, appreciate it! ChangesPlugin now only applies to specified files - Regarding |
cexbrayat
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #422
"extends": ["plugin:playwright/recommended"]