Skip to content

feat(client): improve ui of assets page #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat(client): improve ui of assets page #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/client/src/assets/styles/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,15 @@ body::-webkit-scrollbar {
/* Support Firefox */
scrollbar-width: none;
}

/* Shikiji */
/* refer: https://shikiji.netlify.app/guide/dual-themes#class-based-dark-mode */
html.dark .shiki,
html.dark .shiki span {
color: var(--shiki-dark) !important;
background-color: var(--shiki-dark-bg) !important;
/* Optional, if you also want font styles */
font-style: var(--shiki-dark-font-style) !important;
font-weight: var(--shiki-dark-font-weight) !important;
text-decoration: var(--shiki-dark-text-decoration) !important;
}
2 changes: 1 addition & 1 deletion packages/client/src/components/assets/AssetDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const supportsPreview = computed(() => {
icon="i-carbon-copy"
action mr1 mt--2px flex-none
:border="false"
@click="copy(asset.publicPath, { silent: false, type: 'assets-public-path' })"
@click="copy(asset.publicPath, { type: 'assets-public-path' })"
/>
<RouterLink
:to="asset.publicPath"
Expand Down
8 changes: 6 additions & 2 deletions packages/client/src/components/assets/FilepathItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script setup lang="ts">
import { VTooltip as vTooltip } from '@vue/devtools-ui'

const props = defineProps<{
filepath: string
lineBreak?: boolean
Expand All @@ -7,13 +9,15 @@ const props = defineProps<{

const parsed = computed(() => ({ path: props.filepath }),
)

const { copy } = useCopy()
</script>

<template>
<button
font-mono hover:underline
v-tooltip="'Copy file path'" font-mono hover:underline
:class="lineBreak ? '' : 'ws-nowrap of-hidden truncate'"
:title="filepath"
:title="filepath" @click="copy(filepath)"
>
{{ parsed.path }}
</button>
Expand Down