Skip to content

feat(client): improve behavior of EditInput component #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat(client): improve behavior of EditInput component #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions packages/client/src/components/inspector/InspectorDataField/EditInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@ watch(value, checkWarning())
<span class="flex-inline items-center gap4px">
<VueInput v-model="value" :variant="isWarning ? 'warning' : 'normal'" class="h25px w120px px4px" :auto-focus="autoFocus" @click.stop />
<template v-if="showActions">
<VueButton
v-tooltip="{
content: 'Esc to cancel',
}" size="mini" flat class="p2px!" @click.stop="$emit('cancel')"
>
<template #icon>
<VueIcon icon="i-material-symbols-cancel" />
</template>
</VueButton>
<template v-if="!isWarning">
<VueButton
v-tooltip="{
content: 'Esc to cancel',
}" size="mini" flat class="p2px!" @click.stop="$emit('cancel')"
>
<template #icon>
<VueIcon icon="i-material-symbols-cancel" />
</template>
</VueButton>
<VueButton
v-tooltip="{
content: 'Enter to submit change',
Expand All @@ -74,7 +74,11 @@ watch(value, checkWarning())
</template>
</VueButton>
</template>
<VueIcon v-else icon="i-material-symbols-warning" class="color-warning-500 dark:color-warning-300" />
<VueIcon
v-else v-tooltip="{
content: 'Invalid value',
}" icon="i-material-symbols-warning" class="color-warning-500 dark:color-warning-300"
/>
</template>
</span>
</template>