Skip to content

fix(kit): detect vue doubly-linked node to avoid circular references on encoding #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(kit): detect vue doubly-linked node to avoid circular references on encoding #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/devtools-kit/src/shared/transfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ function isArray(_data: unknown, proto: string): _data is unknown[] {
return proto === '[object Array]'
}

// See https://github1s.com/vuejs/core/blob/HEAD/packages/reactivity/src/dep.ts#L32-L33
function isVueReactiveLinkNode(node) {
const constructorName = node.constructor.name
return (constructorName === 'Dep' && 'activeLink' in node) || (constructorName === 'Link' && 'dep' in node)
}

/**
* This function is used to serialize object with handling circular references.
*
Expand Down Expand Up @@ -41,6 +47,9 @@ function encode(data: unknown, replacer: Replacer | null, list: unknown[], seen:
const index = list.length
const proto = Object.prototype.toString.call(data)
if (isObject(data, proto)) {
if (isVueReactiveLinkNode(data)) {
return index
}
stored = {}
seen.set(data, index)
list.push(stored)
Expand Down