Skip to content

Conversation

Jinjiang
Copy link
Member

Description of Problem

The common IDE option like "Files: Insert Final Newline" in VSCode which add ending lines for files automatically when you save them, causes an additional empty line in the description comment from description.txt in examples.

Proposed Solution

Just trim the desc string in src/examples/util.ts

Additional Information

Original source file:
image

After saving it with the newline option in VSCode:
image

Then the render result:
image

After trimming the desc in util.ts:
image

Thanks.

@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit a257248
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/628c3e9fdafdf200083f11db
😎 Deploy Preview https://deploy-preview-1734--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jinjiang thank you for the improvement 🙇🏻

@NataliaTepluhina NataliaTepluhina merged commit 3a54e46 into vuejs:main May 28, 2022
@Jinjiang Jinjiang deleted the patch-2 branch May 28, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants