Change emit example function name for clarity #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I suggest changing the function name in the "component instance" example from `submit` to `someEvent` (and also possibly adding some extra HTML example code for added clarity) As-is, I did not immediately see the connection between "submit" and the following code, which references "some-event" I'm just learning Vue and was a little confused by this section in the docs. It's very possible I'm still confused, in which case, please disregard :)
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
skirtles-code
suggested changes
Oct 29, 2022
There was a problem hiding this comment.
Thanks for the PR!
I agree that the event name should be changed to match the surrounding examples. The sudden switch to submit just makes it confusing.
I don't think we need the extra template snippet though. How the submit() method gets called isn't really relevant to the point being made.
Sure, that makes sense. I made another commit to remove the snippet! |
skirtles-code
approved these changes
Oct 29, 2022
Alex-Sokolov
referenced
this pull request
in vuejs-translations/docs-ru
Oct 29, 2022
* Change emit example function name for clarity Hello, I suggest changing the function name in the "component instance" example from `submit` to `someEvent` (and also possibly adding some extra HTML example code for added clarity) As-is, I did not immediately see the connection between "submit" and the following code, which references "some-event" I'm just learning Vue and was a little confused by this section in the docs. It's very possible I'm still confused, in which case, please disregard :) * Remove template snippet
Alex-Sokolov
referenced
this pull request
in vuejs-translations/docs-ru
Oct 29, 2022
* Change emit example function name for clarity Hello, I suggest changing the function name in the "component instance" example from `submit` to `someEvent` (and also possibly adding some extra HTML example code for added clarity) As-is, I did not immediately see the connection between "submit" and the following code, which references "some-event" I'm just learning Vue and was a little confused by this section in the docs. It's very possible I'm still confused, in which case, please disregard :) * Remove template snippet Co-authored-by: Ben <ben.austin@melodysquare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
As-is, I did not immediately see the connection between
this.$emit('submit')and the following code,<MyComponent @some-event="callback" />in the "component instance" exampleProposed Solution
I suggest changing the function name from
submittosomeEvent(and also possibly adding some extra HTML example code for added clarity)Additional Information
I'm just learning Vue and was a little confused by this section in the docs. It's very possible I'm still confused, in which case, please disregard :)