Composition API version #2075
Closed
Composition API version #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
skirtles-code
suggested changes
Nov 11, 2022
src/guide/scaling-up/sfc.md
Outdated
Comment on lines
38
to
40
| import { ref } from 'vue'; | ||
| const greeting = ref('Hello World!'); | ||
| } |
There was a problem hiding this comment.
I suggest removing the indent, the semicolons, and the trailing }:
Suggested change
| import { ref } from 'vue'; | |
| const greeting = ref('Hello World!'); | |
| } | |
| import { ref } from 'vue' | |
| const greeting = ref('Hello World!') |
src/guide/scaling-up/sfc.md
Outdated
|
|
||
| ```js | ||
| import MyComponent from './MyComponent.vue' | ||
| <div class="options-api"> |
There was a problem hiding this comment.
I don't think we should change this second example. The current example is intended to show importing a .vue file into a plain .js file. It's supposed to illustrate how .vue files are just ES modules. Showing a .vue importing a .vue doesn't quite make the same point about compatibility with normal JavaScript.
The existing example is valid for both the Options API and the Composition API. The components option is common to both.
|
This PR is superseded by #2145. The commits from this PR are included in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Some code examples were missing the composition API/options API variant, toggle button was not switching between the two variants.
Proposed Solution
Added missing Composition API examples.
Additional Information