Skip to content

fix(reactivity): typo #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2020
Merged

fix(reactivity): typo #214

merged 1 commit into from
Jul 18, 2020

Conversation

yyyanghj
Copy link
Contributor

@yyyanghj yyyanghj commented Jul 18, 2020 •
edited
Loading

Fix a typo

typo2

@NataliaTepluhina NataliaTepluhina requested a review from sdras July 18, 2020 08:00
sdras
sdras requested changes Jul 18, 2020
View reviewed changes
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch on the key, prop typo! However, we want to keep the spread operator. Can you please remove those changes? Then we can merge.

@yyyanghj
Copy link
Contributor Author

Thanks for the catch on the key, prop typo! However, we want to keep the spread operator. Can you please remove those changes? Then we can merge.

Sure. It's done.

@sdras
Copy link
Member

sdras commented Jul 18, 2020

Thank you!

@sdras sdras merged commit 8d7a1bc into vuejs:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdras sdras sdras requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yyyanghj @sdras