State Transitions Page Revamp #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodezen
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
Great job simplifying the transitions explanations and examples!
I had one suggestion regarding renaming fullVal to fullValue since we use oldValue and newValue` and it has the advantage of being consistent while also explicit.
But it's not a hard block for me, feel free to merge without the change if you want. 👍
Co-authored-by: Ben Hong <ben@bencodezen.io>
Co-authored-by: Ben Hong <ben@bencodezen.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the state transitions page and updates all examples to Vue 3.