fix: scope SecurityUpdateBtn css styles #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NataliaTepluhina
approved these changes
Jul 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Recent update 8a4f627 introduced new button component in VitePress theme. CSS styles of this component are not scoped and since
.containeris used several other times, the style leaked:It might not be apparent for page titles. But we spotted it out, because I added specific width in Czech translation. I thought it is only for the button, but it shifted whole layout badly....
Proposed Solution
I believe there was no intention to edit
.containerstyle globally and the simplilest solution is just to addscopedattribute intoSecurityUpdateBtn.vue, which I think is also the recommended way of using styles in components to avoid such situations.Additional Information