Skip to content

Conversation

skirtles-code
Copy link
Contributor

The isHydrate argument of mount is optional so I've added square brackets.

@@ -181,7 +181,7 @@ Apart from `el`, you should treat these arguments as read-only and never modify
- **Arguments:**

- `{Element | string} rootContainer`
- `{boolean} isHydrate`
- `{boolean} [isHydrate]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: could we replace square brackets here with the note about optional component? Like we have on Directives

**Argument:** `attrOrProp (optional)`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be inconsistent with the other optional parameters on this page, so I have created #442 to address that.

If you want to proceed with the (optional) format then this PR can be closed in deference to #442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants