Skip to content

Move the migration and contribution guidelines in separate sections #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Move the migration and contribution guidelines in separate sections #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14ef227
fix: changed sidebar to separate migration guide
NataliaTepluhina Nov 18, 2020
af6e85a
fix: moved contribute section
NataliaTepluhina Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 59 additions & 49 deletions src/.vuepress/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,51 +116,6 @@ const sidebar = {
'/guide/a11y-standards',
'/guide/a11y-resources'
]
},
{
title: 'Migration Guide',
collapsable: true,
children: [
'/guide/migration/introduction',
'/guide/migration/array-refs',
'/guide/migration/async-components',
'/guide/migration/attribute-coercion',
'/guide/migration/attrs-includes-class-style',
'/guide/migration/children',
'/guide/migration/custom-directives',
'/guide/migration/custom-elements-interop',
'/guide/migration/data-option',
'/guide/migration/emits-option',
'/guide/migration/events-api',
'/guide/migration/filters',
'/guide/migration/fragments',
'/guide/migration/functional-components',
'/guide/migration/global-api',
'/guide/migration/global-api-treeshaking',
'/guide/migration/inline-template-attribute',
'/guide/migration/key-attribute',
'/guide/migration/keycode-modifiers',
'/guide/migration/listeners-removed',
'/guide/migration/props-default-this',
'/guide/migration/render-function-api',
'/guide/migration/slots-unification',
'/guide/migration/transition',
'/guide/migration/transition-group',
'/guide/migration/v-on-native-modifier-removed',
'/guide/migration/v-model',
'/guide/migration/v-if-v-for',
'/guide/migration/v-bind',
'/guide/migration/watch'
]
},
{
title: 'Contribute to the Docs',
collapsable: true,
children: [
'/guide/contributing/writing-guide',
'/guide/contributing/doc-style-guide',
'/guide/contributing/translations'
]
}
],
api: [
Expand Down Expand Up @@ -213,6 +168,55 @@ const sidebar = {
'/examples/todomvc'
]
}
],
migration: [
'/guide/migration/introduction',
{
title: 'Details',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the best name but we need something to wrap 'detailed changes'

collapsable: false,
children: [
'/guide/migration/array-refs',
'/guide/migration/async-components',
'/guide/migration/attribute-coercion',
'/guide/migration/attrs-includes-class-style',
'/guide/migration/children',
'/guide/migration/custom-directives',
'/guide/migration/custom-elements-interop',
'/guide/migration/data-option',
'/guide/migration/emits-option',
'/guide/migration/events-api',
'/guide/migration/filters',
'/guide/migration/fragments',
'/guide/migration/functional-components',
'/guide/migration/global-api',
'/guide/migration/global-api-treeshaking',
'/guide/migration/inline-template-attribute',
'/guide/migration/key-attribute',
'/guide/migration/keycode-modifiers',
'/guide/migration/listeners-removed',
'/guide/migration/props-default-this',
'/guide/migration/render-function-api',
'/guide/migration/slots-unification',
'/guide/migration/transition',
'/guide/migration/transition-group',
'/guide/migration/v-on-native-modifier-removed',
'/guide/migration/v-model',
'/guide/migration/v-if-v-for',
'/guide/migration/v-bind',
'/guide/migration/watch'
]
}
],
contributing: [
{
title: 'Contribute to the Docs',
collapsable: false,
children: [
'/guide/contributing/writing-guide',
'/guide/contributing/doc-style-guide',
'/guide/contributing/translations'
]
}
]
}

Expand Down Expand Up @@ -290,10 +294,6 @@ module.exports = {
text: 'Guide',
link: '/guide/introduction'
},
{
text: 'Migration Guide',
link: '/guide/migration/introduction'
},
{
text: 'Style Guide',
link: '/style-guide/'
Expand All @@ -305,6 +305,14 @@ module.exports = {
{
text: 'Examples',
link: '/examples/markdown'
},
{
text: 'Contribute',
link: '/guide/contributing/writing-guide'
},
{
text: 'Migration from Vue 2',
link: '/guide/migration/introduction'
}
]
},
Expand Down Expand Up @@ -396,6 +404,8 @@ module.exports = {
sidebarDepth: 2,
sidebar: {
collapsable: false,
'/guide/migration/': sidebar.migration,
'/guide/contributing/': sidebar.contributing,
'/guide/': sidebar.guide,
'/community/': sidebar.guide,
'/cookbook/': sidebar.cookbook,
Expand Down