Update render-function.md #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Array.apply(null, { length: n })` is too hard to understand.
`Array.from({ length: n })` is much more straightforward in given context. Arrow functions are used in examples, so we can use ES2015.
NataliaTepluhina
approved these changes
Nov 23, 2020
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
`Array.apply(null, { length: n })` is too hard to understand.
`Array.from({ length: n })` is much more straightforward in given context. Arrow functions are used in examples, so we can use ES2015.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify example for a little bit.
Description of Problem
Array.apply(null, { length: n })is too hard to understand.Proposed Solution
Array.from({ length: n })is much more straightforward in given context. Arrow functions are used in examples, so we can use ES2015. Example is for advanced users, so some complexity is fine. Given the textual context the suggested code is clear enough.Additional Information